Skip to content

Usage improvements for S3 bucket weblinks generation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Usage improvements for S3 bucket weblinks generation #1

wants to merge 4 commits into from

Conversation

daviddays
Copy link

@daviddays daviddays commented Jan 9, 2025 •
edited
Loading

This PR includes several small improvements to help the typical user run the script against their own S3 buckets without having to modify the existing python:

  • Addition of main-method check and runtime argument parsing to pass in buckets, templates, etc as parameters
  • Modification of index link generation to add entries for parent directory (if available)
    s3_index_html

ryfeus
ryfeus approved these changes Jan 19, 2025
View reviewed changes
Copy link
Owner

@ryfeus ryfeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryfeus ryfeus ryfeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddays @ryfeus